Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow unranked dynamism in ops that take output shape as an operand #1970

Conversation

mlevesquedion
Copy link
Contributor

@mlevesquedion mlevesquedion commented Jan 30, 2024

This includes:

  • dynamic_broadcast_in_dim
  • dynamic_iota
  • dynamic_reshape

#1991

@mlevesquedion mlevesquedion force-pushed the disallow-unranked-dynamism-in-dynamic-iota branch from 03d23a0 to 1dd008f Compare February 2, 2024 18:31
@mlevesquedion mlevesquedion changed the title Disallow unranked dynamism in dynamic_iota Disallow unranked dynamism in ops that take output shape as an operand Feb 2, 2024
@mlevesquedion mlevesquedion force-pushed the disallow-unranked-dynamism-in-dynamic-iota branch from 1dd008f to d4b8754 Compare February 2, 2024 18:49
This includes:
- dynamic_broadcast_in_dim
- dynamic_iota
- dynamic_reshape

openxla#1881
@mlevesquedion mlevesquedion force-pushed the disallow-unranked-dynamism-in-dynamic-iota branch from d4b8754 to 628bad9 Compare February 5, 2024 20:02
Copy link
Member

@GleasonK GleasonK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let me pull these changes and make sure that the new bytecode files are compatible with previous releases before submit.

stablehlo/dialect/TypeInference.cpp Show resolved Hide resolved
stablehlo/dialect/TypeInference.cpp Show resolved Hide resolved
stablehlo/dialect/TypeInference.cpp Show resolved Hide resolved
@mlevesquedion
Copy link
Contributor Author

Double checked bytecode compatibility; no issues detected.

@mlevesquedion mlevesquedion merged commit be5ef8f into openxla:main Feb 6, 2024
10 checks passed
@mlevesquedion mlevesquedion deleted the disallow-unranked-dynamism-in-dynamic-iota branch February 6, 2024 17:33
mlevesquedion pushed a commit that referenced this pull request Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants